chore: make CodeQL check triggered on pull_request_target #31575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we trigger the workflow on `pull_request`, a human has to approve it. Workflows on `pull_request_target` can run freely.
iliapolo
requested changes
Sep 26, 2024
| @@ -3,14 +3,14 @@ name: "CodeQL" | |||
| on: | |||
| push: | |||
| branches: [ "main" ] | |||
| pull_request: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
We can't. This workflow runs checkout. See https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target
There was a problem hiding this comment.
It runs checkout, but it doesn't run any scripts from the checkout.
Instead, it runs GitHub's Code analyzer ON the checkout.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Decided we're not comfortable with this. There's no guarantee there won't be a buffer overflow in the CodeQL analyzer. |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we trigger the workflow on
pull_request, a human has to approve it.Workflows on
pull_request_targetcan run freely.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license